Ticket #796 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

DiaSource.obsCode should be a string not a single char

Reported by: fpierfed Owned by: rhl
Priority: normal Milestone:
Component: afw Keywords:
Cc: Blocked By:
Blocking: Project: LSST
Version Number:
How to repeat:

not applicable

Description

As you can see at line 119 of DiaSource.cc

    void setObsCode(char  const obsCode) {
        set(_obsCode, obsCode, OBS_CODE);
    }   

obsCode is defined to be a single char. It is a 3 letter code. The database schema is fine, by the way.

Change History

comment:1 Changed 10 years ago by ktl

We generally avoid char*; this should be a std::string.

comment:2 Changed 10 years ago by rhl

  • Status changed from new to closed
  • Resolution set to fixed
  • reviewstatus changed from notReady to selfReviewed
  • Summary changed from DiaSource.obsCode should be char* not char! to DiaSource.obsCode should be a string not a single char

I changed the code to match the schema (using std::string); r9749

Note: See TracTickets for help on using tickets.