Ticket #747 (closed defect: fixed)

Opened 11 years ago

Last modified 8 years ago

Minor PSF cleanups

Reported by: rowen Owned by: rhl
Priority: minor Milestone:
Component: meas_algorithms Keywords:
Cc: Blocked By:
Blocking: Project: LSST
Version Number: 3.0.6
How to repeat:

not applicable


A few minor PSF oddities to clean up:

  • Please consistently use Psf instead of PSF (or get our C++ naming convention for acronyms changed)
  • Regarding Psf.py in meas_algorithms:
    • getPsf has an argument named moPolicy but the policy is for PSF determination, not measuring objects. I suggest renaming it.
  • Please document the inputs and outputs for getPsf, including the entries in the policy.
  • The display flag (which controls whether diagnostic images are displayed in ds9) is set automatically. Please allow users to set this flag (either on a module-wide or per-function), to give more control.

Change History

comment:1 Changed 11 years ago by rowen

In addition, the various means of making PSFs seem very inconsistent:

  • The PSF class has a constructor that takes just a Kernel (makes sense to me) but in addition...
  • There are two different factory functions named createPSF, each of which are entirely different:
    • One takes a Kernel and a PSF type string, which can only be set to "PCA". What is the point of this if one can construct a PSF directly from the same Kernel without specifying a type string?
    • One takes a type string (which must be DoubleGaussian?) and a number of parameters. This one I can understand. I assume in the long run it will accept some other options.

Also, need we use a double gaussian to smooth data before performing source detection? Wouldn't a single Gaussian do as well? A single Gaussian would make smoothing much faster because it is separable.

comment:2 Changed 11 years ago by rhl

  • Status changed from new to assigned

comment:3 Changed 11 years ago by rowen

Also please have import lsst.meas.algorithms automatically import the sub-module Psf (e.g. by adding "import Psf" to init.py)

comment:4 Changed 10 years ago by rhl

  • Status changed from assigned to closed
  • Resolution set to fixed
  • reviewstatus changed from notReady to selfReviewed

The last of these is in r12122 (except the PSF -> Psf rename which is waiting on move of PSF class to afw).

The Policy dictionary is in CrRejectDictionary.paf

comment:5 Changed 8 years ago by robyn

  • Milestone DC3b Apps Framework deleted

Milestone DC3b Apps Framework deleted

Note: See TracTickets for help on using tickets.