Ticket #687 (closed new functionality: fixed)

Opened 11 years ago

Last modified 7 years ago

Persist SdqaRating Objects

Reported by: rlaher Owned by: rlaher
Priority: normal Milestone:
Component: sdqa Keywords:
Cc: Blocked By:
Blocking: Project: LSST
Version Number:
How to repeat:

not applicable

Description

Add a new class to SdqaRating?.h called PersistableSdqaRatingVector? for persisting SdqaRating? objects in the database, swig this into python, and implement a formatter and unit test.

Change History

comment:1 Changed 11 years ago by ktl

I'm not sure why SdqaRatingSet isn't the persistable class, inheriting from both lsst::daf::base::Persistable and std::vector<SdqaRating::Ptr>.

comment:2 Changed 11 years ago by rlaher

  • Status changed from new to assigned

I think it could also be set up that way, but this is how it is set up for class PersistableSourceVector?. Until I climb higher up the LSST-framework learning curve and figure out how SourceSet? is used in and of itself (I do not know what gotchas may by lurking if I bypass SdqaRatingSet?), I think it is best for me to follow what was done for Source. Moreover, this way, I think actually stand a chance of having this implemented by Monday!

comment:3 Changed 11 years ago by rlaher

  • Status changed from assigned to inTicketWork

comment:4 Changed 11 years ago by ktl

I see. I didn't notice what Martin had done. I'll have to take this up with him as well for post-DC3a.

comment:5 Changed 11 years ago by rlaher

  • Owner changed from rlaher to robyn
  • Status changed from inTicketWork to inStandardsReview

Far from perfect, but ready for DC3a. Would like to merge this into trunk and cut new release.

comment:6 Changed 11 years ago by robyn

  • Owner changed from robyn to rlaher

Comments regarding coding standards review:

  • style is consistent with LSST coding standards Definitive would will occur when automatic standards checker is available.
  • code should not be commented out. If it's in transition, then comment why and when it will be incorporated or remove the unusable code.

Is there a way to automatically generate the pre-test build of the operating environment? All tests should run via an automatic process.

I didn't build or run the tests.

Assuming all tests run for you, merge onto the trunk.

comment:7 Changed 11 years ago by robyn

  • Status changed from inStandardsReview to inTrunkMerge

comment:8 Changed 11 years ago by rlaher

  • Owner changed from rlaher to robyn
  • Status changed from inTrunkMerge to inQaReview

Per Robyn's review:

  1. Either removed commented code, or added explanatory note.
  2. Set-up of database for persistence test cannot be easily done in an automated fashion.
  3. All tests including database-persistence test passed.
  4. Merged into trunk.

comment:9 Changed 10 years ago by robyn

  • Status changed from inQaReview to closed
  • Resolution set to fixed

Closing out ticket.

comment:10 Changed 10 years ago by robyn

  • Owner changed from robyn to rlaher

comment:11 Changed 7 years ago by robyn

  • Milestone DC3a Apps SDQA deleted

Milestone DC3a Apps SDQA deleted

Note: See TracTickets for help on using tickets.