Ticket #685 (closed enhancement: fixed)

Opened 11 years ago

Last modified 7 years ago

Needed changes to sdqa package

Reported by: rlaher Owned by: rlaher
Priority: normal Milestone:
Component: sdqa Keywords:
Cc: Blocked By:
Blocking: Project: LSST
Version Number:
How to repeat:

not applicable

Description

In conformance with C++ programming guidelines, change "using namespace lsst::sdqa;" to "namespace sdqa = lsst::sdqa;" in all .cc files in "src" and "tests" directories, and qualify all names with "sdqa::".

Also, modify the SDQA rating class to have a vector of SDQA rating objects, and allow this in the swig interface to python.

Change History

comment:1 Changed 11 years ago by rlaher

  • Status changed from new to assigned

comment:2 Changed 11 years ago by rlaher

  • Status changed from assigned to inTicketWork

comment:3 Changed 11 years ago by rlaher

  • Owner changed from rlaher to robyn
  • Status changed from inTicketWork to inStandardsReview

This is a logical stopping point for this part of the work. I will close this ticket and open another ticket to continue the work into the next phase, which is to add a new class to SdqaRating?.h called PersistableSdqaRatingVector?. In order to implement a unit test for the new class, a formatter will have to be implemented, as well, and so this work will all be done under the same ticket.

comment:4 Changed 11 years ago by robyn

  • Owner changed from robyn to rlaher

Please include the changeset number(s) which corresponds to the commit for this package either in the ticket branch or the 'final' trunk merge.

Changeset: [7810]

The changes are reasonable.

Henceforth, changes to this package should be done in a ticket branch and not directly on the trunk unless the change amounts to a trivial fix which is less than 30 lines in length. (This exception to the rule has still not been passed by the TCT, though.)

I am closing the ticket since it is already on the trunk.

comment:5 Changed 11 years ago by robyn

  • Status changed from inStandardsReview to inTrunkMerge

comment:6 Changed 11 years ago by robyn

  • Owner changed from rlaher to robyn
  • Status changed from inTrunkMerge to inQaReview

comment:7 Changed 11 years ago by robyn

  • Status changed from inQaReview to closed
  • Resolution set to fixed

comment:8 Changed 11 years ago by robyn

  • Owner changed from robyn to rlaher

comment:9 Changed 7 years ago by robyn

  • Milestone DC3a Apps Framework deleted

Milestone DC3a Apps Framework deleted

Note: See TracTickets for help on using tickets.