Ticket #374 (closed enhancement: fixed)

Opened 11 years ago

Last modified 7 years ago

Utilize improved support for shared_ptr in SWIG 1.3.35+

Reported by: smm Owned by: smm
Priority: normal Milestone:
Component: unknown Keywords: swig shared_ptr
Cc: smm Blocked By: #375, #434
Blocking: Project: LSST
Version Number:
How to repeat:

not applicable

Description

SWIG versions 1.3.35 and up have direct support for boost::shared_ptr, which means we can remove:

  • our custom shared_ptr wrapper
  • almost all of our (complex) persistence typemaps
  • helper functions for correctly creating shared pointers in Python

This affects most of our packages, including

  • utils
  • daf_base
  • daf_persistence
  • pex_logging
  • pex_policy
  • afw

and most (if not all) pipelines, though required fixes are not expected to be hard.

Change History

comment:1 Changed 11 years ago by smm

  • Blocked By 375 added

comment:2 Changed 11 years ago by smm

  • Keywords swig shared_ptr added

comment:3 Changed 11 years ago by smm

  • Status changed from new to assigned
  • Owner changed from smm to ktl
  • reviewstatus changed from notReady to needsReview

comment:4 Changed 11 years ago by ktl

  • Status changed from assigned to inTicketWork

comment:5 Changed 11 years ago by ktl

  • Status changed from inTicketWork to assigned
  • Owner changed from ktl to smm

Serge is actually going to do this as I have been overloaded.

comment:6 Changed 11 years ago by rhl

  • Blocked By 434 added

comment:7 Changed 11 years ago by smm

  • Status changed from assigned to closed
  • Resolution set to fixed
  • reviewstatus changed from needsReview to selfReviewed

These changes were merged to trunk on 11/14/2008, see revisions [6321], [6317], [6313], [6309], [6305], [6300], [6290]. Two associated patches to SWIG 1.3.36 were produced - one to fix generated python package names resulting from module %import, and another to handle multiple inheritance for classes wrapped with SWIG_SHARED_PTR(). So far, only the first patch has been committed for swig 1.3.37.

comment:8 Changed 7 years ago by robyn

  • Milestone DC3 Infrastructure Prep deleted

Milestone DC3 Infrastructure Prep deleted

Note: See TracTickets for help on using tickets.