Ticket #1573 (closed enhancement: fixed)

Opened 8 years ago

Last modified 8 years ago

Unify PSF fitting

Reported by: rowen Owned by: rowen
Priority: normal Milestone:
Component: meas_algorithms Keywords:
Cc: jarvis, rhl, bick Blocked By:
Blocking: Project: LSST
Version Number:
How to repeat:

Description

Please unify PSF fitting so that it is easy to use different algorithms, e.g. as specified by a policy file. Implementation should include:

  • Unify the API of the two existing star selection algorithms
  • Unify the API of the two existing PSF fitting algorithms
  • Implement a registry for star selection algorithms and for psf fitting algorithms to make it easy to add new algorithms (without changing code in meas_algorithms) and to select an algorithm by name

My plans include:

  • The standard star selector will be a class that takes a policy in its constructor and selects stars via a method that takes a collection of sources and returns a collection of PsfCandidates?. This is a minor variation on Mike Jarvis' StarFinder?.
  • The standard PSF fitter will be a class that takes a policy in its constructor and fits PSFs via a method that takes a collection of PsfCandidates? and returns the resulting Psf.

Other important points:

  • Star selectors and Psf fitters are allowed to be written in C++ or Python. Note that one implementation is already pure python. Note that pure Python can give acceptable performance for this kind of job.
  • As a result (and to avoid the need for C++ to call Python code) the registry will be at the Python level. Thus one must use Python to use the fully unified interface.

Change History

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc jarvis, rhl, bick added; jarvis rhl removed

comment:2 Changed 8 years ago by rowen

  • Status changed from new to assigned

comment:3 Changed 8 years ago by rowen

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed by meas_algorithms 4.3.1.0. The shapelet psf determiner and new star selector needs unit tests, but I view that as independent of this ticket.

Note: See TracTickets for help on using tickets.