Ticket #1455 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Improve source measurement policy handling

Reported by: ktl Owned by: ktl
Priority: normal Milestone:
Component: meas_algorithms Keywords:
Cc: rhl, bick Blocked By:
Blocking: Project: LSST
Version Number:
How to repeat:

not applicable

Description (last modified by ktl) (diff)

Source measurement now has code in afw, meas_algorithms, and meas_pipeline that use policies to configure which measurement algorithms are used and to configure the algorithms themselves. The handling of these policies needs improvement:

  • Dictionaries are scattered across the packages, including at least one unused one in meas_pipeline:MeasureSourcesDictionary.paf and another in meas_utils.
  • Defaults are provided in both dictionaries and separate policy files (because plugins are difficult to specify in dictionaries). Sometimes these overlap.
  • The default policy files are also scattered across packages, including at least one unused one in meas_pipeline:MeasureSources.paf.
  • In at least one place, the measureSources policy that controls the source measurement code in afw is embedded within a higher-level measureSources policy. This is confusing and leads to errors and hacky code that tries to find the right sub-policy.
  • The merging of actual policy files, default policy files, and dictionaries is not handled in an ideal way. Much of this happens at the pipeline stage level when it should really happen much lower (in meas_algorithms).
  • Ideally, each plugin algorithm should have its own dictionary for its policy configuration.
  • Algorithms are enabled by specifying their names as sub-policy names, along with "exists: true" (to ensure that the sub-policy is not empty). There is currently no means of disabling an algorithm that is enabled by the default policy. "enabled: true"/"enabled: false" is suggested as a replacement for "exists: true".

Change History

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc rhl, bick added

comment:2 Changed 9 years ago by ktl

  • Status changed from new to assigned
  • Description modified (diff)

Branches created in [17056] (afw), [17057] (meas_algorithms), [17058] (meas_utils), [17059] (meas_pipeline).

comment:3 Changed 9 years ago by ktl

  • Status changed from assigned to closed
  • Resolution set to fixed

All of the above points except per-algorithm dictionaries were implemented in [17060], [17062], [17063], [17065], [17066], [17067], [17077].

These were merged to trunk in [17078], [17080], and [17082].

Note: See TracTickets for help on using tickets.