Ticket #1084 (closed enhancement: fixed)

Opened 10 years ago

Last modified 10 years ago

Skeletal stage for SDQA WCS verification

Reported by: rlaher Owned by: rlaher
Priority: normal Milestone:
Component: sdqa Keywords:
Cc: shaw Blocked By:
Blocking: Project: LSST
Version Number:
How to repeat:

not applicable

Description

Create a skeletal stage for SDQA WCS verification and associated policy dictionary.

Change History

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc shaw added

comment:2 Changed 10 years ago by rlaher

  • Status changed from new to assigned

comment:3 Changed 10 years ago by rlaher

  • Status changed from assigned to inTicketWork

comment:4 Changed 10 years ago by rlaher

  • Status changed from inTicketWork to inStandardsReview
  • Owner changed from rlaher to robyn

comment:5 Changed 10 years ago by robyn

Embedded is the C++ Standards Check on sdqa trunk version 12809.

Since I am currently handling the Standards Check on a secondary GUI-only system (leaving the primary CLI-driven system available for testing the Checkers' inclusion into buildbot), there is no archive copy of this output NOR is there an associated logfile.

/sdqa/src/SdqaRating.cc
109: 	Private non-boolean member function name, setParentDbId, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
118: 	Private non-boolean member function name, setSdqaMetricId, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
122: 	Private non-boolean member function name, setSdqaMetricName, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
126: 	Private non-boolean member function name, setSdqaThresholdId, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
151: 	Private non-boolean member function name, getParentDbId, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
155: 	Private non-boolean member function name, getSdqaMetricId, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
159: 	Private non-boolean member function name, getSdqaThresholdId, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
-
/sdqa/src/SdqaRatingFormatter.cc
64: 	Private non-boolean member function name, createInstance, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
69: 	Private non-boolean member variable, registration, should have prefix '_' and follow with lowercase letter (camelCase). 	LsstDm-3-2a-3
81: 	Private non-boolean member function name, insertRow, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
110: 	Private non-boolean member function name, setupFetch, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
482: 	Private non-boolean member function name, extractExposureId, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
489: 	Private non-boolean member function name, extractCcdExposureId, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
496: 	Private non-boolean member function name, extractAmpExposureId, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
508: 	Private non-boolean member function name, extractSdqaRatingScope, should start with leading '_' followed by lowercase in camelCase. 	LsstDm-3-4a-3
-
/sdqa/tests/testSdqaImageStatus.cc
33: 	Global or Local variable, 'SdqaImageStatusSuite_registrar33', shall begin with leading lowercase in camelCase 	LsstDm-3-2a-3
-
/sdqa/tests/testSdqaMetric.cc
34: 	Global or Local variable, 'SdqaMetricSuite_registrar34', shall begin with leading lowercase in camelCase 	LsstDm-3-2a-3
-
/sdqa/tests/testSdqaRating.cc
34: 	Global or Local variable, 'SdqaRatingSuite_registrar34', shall begin with leading lowercase in camelCase 	LsstDm-3-2a-3
-
/sdqa/tests/testSdqaRatingSet.cc
34: 	Global or Local variable, 'SdqaRatingSetSuite_registrar34', shall begin with leading lowercase in camelCase 	LsstDm-3-2a-3
-
/sdqa/tests/testSdqaThreshold.cc
33: 	Global or Local variable, 'SdqaThresholdSuite_registrar33', shall begin with leading lowercase in camelCase 	LsstDm-3-2a-3
-

comment:6 Changed 10 years ago by robyn

  • Status changed from inStandardsReview to closed
  • Resolution set to fixed

Embedded is the Python Standards Check on sdqa trunk version 12809.

Since I am currently handling the Standards Check on a secondary GUI-only system (leaving the primary CLI-driven system available for testing the Checkers' inclusion into buildbot), there is no archive copy of this output.

This Ticket will be closed. Please open a new Ticket to address any significant infractions noted in the python or C++ reports.

python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:12: [W0511] TODO: import extractedSources class
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:14: [W0232, SdqaWcsFailureCheckStageParallel] Class has no __init__ method
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:143: [W0104, SdqaWcsFailureCheckStageParallel.process] Statement seems to have no effect
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:144: [E0602, SdqaWcsFailureCheckStageParallel.process] Undefined variable 'extractedSources'
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:170: [W0104, SdqaWcsFailureCheckStageParallel.process] Statement seems to have no effect
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:178: [E0602, SdqaWcsFailureCheckStageParallel.process] Undefined variable 'pexExcept'
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:180: [E0602, SdqaWcsFailureCheckStageParallel.process] Undefined variable 'pexExcept'
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:136: [W0612, SdqaWcsFailureCheckStageParallel.process] Unused variable 'extractedSourceSet'
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:109: [W0201, SdqaWcsFailureCheckStageParallel.setup] Attribute 'extractedSourceSetKey' defined outside __init__
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:104: [W0201, SdqaWcsFailureCheckStageParallel.setup] Attribute 'maxRmsRadDist' defined outside __init__
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:112: [W0201, SdqaWcsFailureCheckStageParallel.setup] Attribute 'log' defined outside __init__
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:108: [W0201, SdqaWcsFailureCheckStageParallel.setup] Attribute 'ccdMetadataKey' defined outside __init__
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:110: [W0201, SdqaWcsFailureCheckStageParallel.setup] Attribute 'astromVerifSdqaRatingsKey' defined outside __init__
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:106: [W0201, SdqaWcsFailureCheckStageParallel.setup] Attribute 'minStellarity' defined outside __init__
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:105: [W0201, SdqaWcsFailureCheckStageParallel.setup] Attribute 'matchRadius' defined outside __init__
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:99: [W0201, SdqaWcsFailureCheckStageParallel.setup] Attribute 'policy' defined outside __init__
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:103: [W0201, SdqaWcsFailureCheckStageParallel.setup] Attribute 'minMatches' defined outside __init__
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:107: [W0201, SdqaWcsFailureCheckStageParallel.setup] Attribute 'nLocalBkgSigma' defined outside __init__
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:98: [E0203, SdqaWcsFailureCheckStageParallel.setup] Access to member 'policy' before its definition line 99
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:184: [W0232, SdqaWcsFailureCheckStage] Class has no __init__ method
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:184: [R0903, SdqaWcsFailureCheckStage] Too few public methods (0/2)
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:189: [E0602] Undefined variable 'main'
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:11: [W0611] Unused import dafBase
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:8: [W0611] Unused import LsstCppException
python/lsst/sdqa/pipeline/sdqaWcsFailureCheckStage.py:9: [W0611] Unused import afwImage
python/lsst/sdqa/pipeline/__init__.py:1: [W0403] Relative import 'sdqaWcsFailureCheckStage'
python/lsst/sdqa/pipeline/__init__.py:1: [W0401] Wildcard import sdqaWcsFailureCheckStage
tests/sdqaWcsFailureCheckStageTest.py:95: [W0622, run] Redefining built-in 'exit'
tests/sdqaWcsFailureCheckStageTest.py:18: [W0611] Unused import harnessStage
tests/sdqaWcsFailureCheckStageTest.py:17: [W0611] Unused import pexHarness
tests/sdqaWcsFailureCheckStageTest.py:20: [W0611] Unused import sdqa
tests/sdqaWcsFailureCheckStageTest.py:11: [W0611] Unused import os

comment:7 Changed 10 years ago by robyn

  • Owner changed from robyn to rlaher
Note: See TracTickets for help on using tickets.